-
Notifications
You must be signed in to change notification settings - Fork 199
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Early start to supporting sourcemaps. #224
base: develop
Are you sure you want to change the base?
Early start to supporting sourcemaps. #224
Conversation
Signed-off-by: Kevin Swiber <[email protected]>
Signed-off-by: Kevin Swiber <[email protected]>
@kevinswiber Could you expand your last comment? My understanding is:
Is the blocker that even keeping the IDs the same will cause the collection feed to show a diff for all requests? |
@abhijitkane When updating a collection via the Postman API, if IDs for folders and responses are set, they persist. This means we can get more granular updates for these in Postman Version Control. However, for requests, the IDs do not persist on a collection update. The request IDs are all regenerated, despite being set, and Postman Version Control marks them all as new while all previous ones are removed. This makes it really difficult to review modifications between transpile events. |
@@ -711,13 +715,17 @@ module.exports = { | |||
// Add all folders created from tags and corresponding operations | |||
// Iterate from bottom to top order to maintain tag order in spec | |||
_.forEachRight(tagFolders, (tagFolder, tagName) => { | |||
const sourceMapKey = `#/folders/${encodeURIComponent(resource.name)}`; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be tagName
A work in progress towards #220.
Signed-off-by: Kevin Swiber [email protected]